Batch builder API#98
Draft
gbrgr wants to merge 13 commits into
Draft
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Arrow.jl returns Arrow.Date/Arrow.Timestamp wrappers, not Dates.Date/DateTime. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rge Julia finalize arms Removes ~130 lines of duplicated identity/scatter dispatch in append_numeric by introducing two declarative macros. Merges JULIA_DATE/TIMESTAMP/TIMESTAMPTZ finalize arms with their non-Julia counterparts since the Arrow output type is identical. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This reverts commit dfdb437.
This reverts commit 8db1a0b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GatheredColumn/GatheredBatchAPI — removed ~350 lines of Julia and Rust code. The old gather API accumulated slices in Julia memory before writing; all callers now useColumnBatchBuilderdirectly.ColumnBatchwrites throughColumnBatchBuilderinternally —write_columns_innerin Rust now uses the builder instead of the retiredbuild_arrow_array_gatheredpath, makingColumnBatchBuilderthe single canonical copy path.SliceBatchJulia API — high-level wrapper that constructsSliceRefstructs from plain Julia arrays, so users don't need to manage raw pointers.batch_builder.rscleanup — extractedappend_primitive!andappend_transform!macros, reducingappend_numericfrom 147 to 35 lines; merged duplicateJULIA_DATE/JULIA_TIMESTAMP/JULIA_TIMESTAMPTZfinalize arms with their non-Julia counterparts (−67 lines total).