Conversation
Signed-off-by: Alexandre van Beurden <1949482+alexvbrdn@users.noreply.github.com>
Signed-off-by: Alexandre van Beurden <1949482+alexvbrdn@users.noreply.github.com>
- js.yml -> ci.yml, named CI, matrix job names and named steps matching the other two SDKs; dropped the REGEXSOLVER_API_TOKEN secret, the tests are mocked with axios-mock-adapter and never call the API - publish.yml: named jobs, npm cache on both, tests before publishing - README claimed Node.js >= 16 while CI's floor is 18; aligned both and added the matching engines field to package.json - README: added the ResponseFormat.ANY note the Python README already had, fixed a typo - .gitignore was the TypeScript compiler's boilerplate and ignored package-lock.json, which is tracked and required by npm ci - removed the stale root .openapi-generator metadata; generation writes to src/generated, which carries its own Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: Alexandre van Beurden <1949482+alexvbrdn@users.noreply.github.com> Signed-off-by: Alexandre van Beurden <1949482+alexvbrdn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.