Skip to content

Conversation

@tristan-f-r
Copy link
Collaborator

@tristan-f-r tristan-f-r commented Sep 20, 2025

While this only affects actual runtime code with an updated, consistent error message on malformed data, the goal of MissingDataError is to create a finer distinction between actual unexpected SPRAS errors and expected one, to further #21 (comment). Closes #393.

@tristan-f-r tristan-f-r added the refactor Changes that don't actually improve anything except for code quality. label Sep 20, 2025
@read-the-docs-community
Copy link

read-the-docs-community bot commented Sep 20, 2025

Documentation build overview

📚 spras | 🛠️ Build #31038933 | 📁 Comparing e9fec74 against latest (de03d52)


🔍 Preview build

Show files changed (4 files in total): 📝 4 modified | ➕ 0 added | ➖ 0 deleted
File Status
genindex.html 📝 modified
htcondor.html 📝 modified
fordevs/modules.html 📝 modified
fordevs/spras.html 📝 modified

@tristan-f-r tristan-f-r added the P-medium medium prirotity; this is needed for some external service or another PR label Sep 25, 2025
@tristan-f-r tristan-f-r added the tuning Workflow-spanning algorithm tuning label Oct 10, 2025
@github-actions github-actions bot added the merge-conflict This PR has merge conflicts. label Oct 11, 2025
@github-actions github-actions bot added merge-conflict This PR has merge conflicts. and removed merge-conflict This PR has merge conflicts. labels Oct 11, 2025
@github-actions github-actions bot removed the merge-conflict This PR has merge conflicts. label Oct 14, 2025
Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to break the get_node_columns signature? Adding the checks within get_node_* functions makes sense to me, as does the new error type in general. My understanding is that the scope argument exists only so we can pass it through to the error message. That is more readable, but adds overhead in using these functions. The alternative would be to use the stack trace to see which algorithm generated the error.

Those are my initial thoughts before a deep review.

@tristan-f-r
Copy link
Collaborator Author

Agreed. I've dropped the scope parameter.

Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one more question that recurs across multiple files.

@agitter agitter merged commit bf8bea8 into Reed-CompBio:main Jan 17, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P-medium medium prirotity; this is needed for some external service or another PR refactor Changes that don't actually improve anything except for code quality. tuning Workflow-spanning algorithm tuning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Algorithm compatibility errors

2 participants