Conversation
|
Moving this back to a draft because I need to handle rank information. |
|
This will be updated after #261 gets merged. |
annaritz
left a comment
There was a problem hiding this comment.
New image (tagged as v1 and as latest for DIAMOnD now pushed to DockerHub: https://hub.docker.com/repository/docker/reedcompbio/diamond/general
Some minor comments/questions, but otherwise looks straightforward.
|
Still a little unclear how seed weights are incorporated (should they be prizes, then?) Also, do you know why tests are failing? |
|
Oh! The I just went through DIAMoND, and I'll update the description to reflect this, but DIAMOnD does not take any weights per node/edge. However, DIAMOnD does assign an integer prize to all prizes, to change how much prizes affect the overall pathway construction. Specifically [in code], prizes are used to assign edge weights. DIAMOnD can actually be modified (in code, not during wrapping) to specifically take in prizes per node. |
|
Good to know that DIAMOnD could be modified (but let's not do that now, that would be a different alg). I pushed the https://hub.docker.com/repository/docker/reedcompbio/diamond/tags |
I'll do container error handling in the next commit
|
There is an actual CI failure! I am not sure exactly, but I believe DIAMOnD fails reconstruction if the provided |
annaritz
left a comment
There was a problem hiding this comment.
Ok, after thinking about the alpha parameter I get it now (it's something passed to DIAMOnD, not something that requires input file modification). That's where my confusion was - the code and the comments are all correct.
All tests pass with the linux/amd64 images! I'm approving for merging.
Another disease module mining algorithm to complement #240 (#109). Closes #244.
Note that, in compliance with #246, DIAMOnD is MIT licensed.