Skip to content

Comments

feat: DIAMOnD#247

Merged
tristan-f-r merged 42 commits intoReed-CompBio:mainfrom
tristan-f-r:diamond
Feb 20, 2026
Merged

feat: DIAMOnD#247
tristan-f-r merged 42 commits intoReed-CompBio:mainfrom
tristan-f-r:diamond

Conversation

@tristan-f-r
Copy link
Collaborator

@tristan-f-r tristan-f-r commented May 30, 2025

Another disease module mining algorithm to complement #240 (#109). Closes #244.

Note that, in compliance with #246, DIAMOnD is MIT licensed.

@tristan-f-r tristan-f-r added the algorithm Pathway reconstruction algorithm to add to SPRAS label May 30, 2025
@tristan-f-r tristan-f-r marked this pull request as ready for review May 30, 2025 22:12
@tristan-f-r tristan-f-r marked this pull request as draft May 30, 2025 22:14
@tristan-f-r
Copy link
Collaborator Author

Moving this back to a draft because I need to handle rank information.

@tristan-f-r tristan-f-r added the discussion Further information is requested label May 30, 2025
@tristan-f-r
Copy link
Collaborator Author

This will be updated after #261 gets merged.

@tristan-f-r tristan-f-r marked this pull request as ready for review July 8, 2025 16:33
@tristan-f-r tristan-f-r removed the discussion Further information is requested label Jul 11, 2025
@tristan-f-r tristan-f-r mentioned this pull request Jul 16, 2025
@github-actions github-actions bot added the merge-conflict This PR has merge conflicts. label Jan 9, 2026
@github-actions github-actions bot removed the merge-conflict This PR has merge conflicts. label Jan 10, 2026
@tristan-f-r tristan-f-r added the awaiting-author Author of the PR needs to fix something from a review / etc. label Jan 10, 2026
@tristan-f-r tristan-f-r removed the awaiting-author Author of the PR needs to fix something from a review / etc. label Jan 10, 2026
@tristan-f-r tristan-f-r added awaiting-author Author of the PR needs to fix something from a review / etc. and removed awaiting-author Author of the PR needs to fix something from a review / etc. labels Jan 23, 2026
@github-actions github-actions bot added the merge-conflict This PR has merge conflicts. label Jan 31, 2026
@github-actions github-actions bot removed the merge-conflict This PR has merge conflicts. label Jan 31, 2026
Copy link
Contributor

@annaritz annaritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New image (tagged as v1 and as latest for DIAMOnD now pushed to DockerHub: https://hub.docker.com/repository/docker/reedcompbio/diamond/general

Some minor comments/questions, but otherwise looks straightforward.

@annaritz
Copy link
Contributor

Still a little unclear how seed weights are incorporated (should they be prizes, then?)

Also, do you know why tests are failing?

@tristan-f-r
Copy link
Collaborator Author

tristan-f-r commented Feb 19, 2026

Oh! The diamond images need to be pushed with linux/amd64 instead of just linux/arm64.

I just went through DIAMoND, and I'll update the description to reflect this, but DIAMOnD does not take any weights per node/edge. However, DIAMOnD does assign an integer prize to all prizes, to change how much prizes affect the overall pathway construction. Specifically [in code], prizes are used to assign edge weights. alpha = 1 itself does nothing, but an alpha greater than one gives more attention to the seed nodes than other nodes after the first DIAMOnD reconstruction iteration.

DIAMOnD can actually be modified (in code, not during wrapping) to specifically take in prizes per node.

@annaritz
Copy link
Contributor

Good to know that DIAMOnD could be modified (but let's not do that now, that would be a different alg).

I pushed the linux/amd64 versions with latest and v1 tags. That means that the linux/arm64 versions no longer have those tags (should that matter?).

https://hub.docker.com/repository/docker/reedcompbio/diamond/tags

@tristan-f-r
Copy link
Collaborator Author

There is an actual CI failure! I am not sure exactly, but I believe DIAMOnD fails reconstruction if the provided n is one less than the network size. The last two commits address this and wrap the error with a nice display message wrapping the original opaque error.

Copy link
Contributor

@annaritz annaritz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, after thinking about the alpha parameter I get it now (it's something passed to DIAMOnD, not something that requires input file modification). That's where my confusion was - the code and the comments are all correct.

All tests pass with the linux/amd64 images! I'm approving for merging.

@tristan-f-r tristan-f-r merged commit 479842d into Reed-CompBio:main Feb 20, 2026
20 checks passed
@tristan-f-r tristan-f-r deleted the diamond branch February 20, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

algorithm Pathway reconstruction algorithm to add to SPRAS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add DIAMOnD

3 participants