Refactor argument parsing and fix building on musl-based sytems#20
Open
CuriouslyCurious wants to merge 7 commits intoRedrrx:mainfrom
Open
Refactor argument parsing and fix building on musl-based sytems#20CuriouslyCurious wants to merge 7 commits intoRedrrx:mainfrom
CuriouslyCurious wants to merge 7 commits intoRedrrx:mainfrom
Conversation
On Alpine the linker is not named just musl-gcc, thus causing any builds to fail. Cargo detects the linker just fine without this.
Reason is log4rs usesderive macros which are not statically compilable on musl-based systems which makes it impossible to create an entirely statically linked binary
clap-derive causes build failures when using '-crt-static', so it was replaced with clap-builder. Argument parsing was overhauled to be less redundant and more clear.
This allows `cargo install` to work on musl-systems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR overhauls the argument-parsing to use more descriptive names as well as to use
clap-builderinstead ofclap-deriveto facilitate a completely static build on musl-based systems.This also replaces
log4rswithfernfor the same static build reason, functionality should be the same.