CMake: use list of experimental feature UUIDs per Cmake version#11
Conversation
📝 WalkthroughWalkthroughCMake configuration was made version-aware: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@CMakeLists.txt`:
- Around line 3-9: The branch with elseif (CMAKE_VERSION VERSION_GREATER_EQUAL
"4.0.0") is unreachable given cmake_minimum_required(VERSION 4.2); remove that
elseif block (the lines that set CMAKE_EXPERIMENTAL_CXX_IMPORT_STD for
"a9e1cf81-9932-4810-974b-6eccaf14e457") to eliminate dead code, or alternatively
lower cmake_minimum_required to 4.0.0 if you truly need to support 4.0.0–4.0.2;
update CMake logic around CMAKE_VERSION and the remaining
set(CMAKE_EXPERIMENTAL_CXX_IMPORT_STD ...) branches accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6397cc07-77c0-4441-8292-188f472413a0
📒 Files selected for processing (2)
CMakeLists.txtCMakePresets.json
|
@mcdubhghlas @Arctis-Fireblight Please review & merge, I need it for the rendering submodules PR & RHI. Thanks. |
Temporarily provide a short list of possible C++23 modules experimental feature UUIDs for a few different CMake versions.
Minimum CMake version currently is 4.0.0
Summary by CodeRabbit