feat: add support for OAuth clientCredential and password flows in Respect core#2824
Open
harshit078 wants to merge 23 commits into
Open
feat: add support for OAuth clientCredential and password flows in Respect core#2824harshit078 wants to merge 23 commits into
harshit078 wants to merge 23 commits into
Conversation
🦋 Changeset detectedLatest commit: 912da7e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a98fd8c. Configure here.
Contributor
Author
|
Hey @DmitryAnansky , can you take review the PR please ? Thanks ! |
Contributor
Performance Benchmark (Lower is Faster)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What/Why/How?
x-securityschemes with thepasswordandclientCredentialsflows.tokenUrland applyAuthorization: Bearerto the request, which allows to manually obtain aaccessTokenReference
#2122
Testing
Screenshots (optional)
Check yourself
Security
Note
High Risk
Changes authentication behavior: credentials are sent to external
tokenUrlendpoints and tokens are injected into requests; incomplete validation could leak calls with secrets before exchange fails.Overview
Respect can automatically obtain OAuth2 access tokens for Arazzo
x-securitywhen schemes declareclientCredentialsorpasswordflows, then sendAuthorization: Beareron workflow requests. A newexchangeOAuth2Tokenhelper POSTs totokenUrl(Basic auth orclientAuthMethod: body), caches tokens onTestContextwith expiry refresh, and registers secrets for masking.resolveXSecurityParametersis now async (includingprepareRequest); it validates credentials, exchanges when appropriate, and still skips the token endpoint if a non-emptyaccessTokenis already set. Runtime validation and thex-security-scheme-required-valueslint rule no longer treat OAuth2 as always requiringaccessToken—they requireclientId/clientSecretorusername/passwordper flow (oraccessTokenfor implicit-only / manual use). EmptyaccessTokenfalls back to flow credentials.Tests cover exchange, cache expiry, pre-fetched tokens, and lint cases. A changeset marks minor bumps for
@redocly/respect-core,@redocly/openapi-core, and@redocly/cli.Reviewed by Cursor Bugbot for commit 912da7e. Bugbot is set up for automated code reviews on this repo. Configure here.