chore: extend respect event#2818
Open
DmitryAnansky wants to merge 2 commits into
Open
Conversation
|
Contributor
|
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Extended respect event with additional fields
Reference
https://github.com/Redocly/redocly/pull/23264
Testing
Screenshots (optional)
Check yourself
Security
Note
Low Risk
Low risk: this only adds two new optional telemetry fields for
arazzo1specs and does not change command execution behavior beyond extra data collection/serialization.Overview
Extends the CLI telemetry (respect event) for
arazzo1specs to also reportrespect_source_description_types(uniquesourceDescriptions[].type) andrespect_criterion_object_types(unique criteriontypevalues gathered from workflow/step/actions and reusable components).Updates
commandWrapperto collect these values during spec parsing and passes them tosendTelemetry, which conditionally serializes them into the emitted event. Adds unit tests covering the new collectors and the updated telemetry payload shape.Reviewed by Cursor Bugbot for commit 87e6754. Bugbot is set up for automated code reviews on this repo. Configure here.