Skip to content

chore: extend respect event#2818

Open
DmitryAnansky wants to merge 2 commits into
mainfrom
chore/extend-respect-event
Open

chore: extend respect event#2818
DmitryAnansky wants to merge 2 commits into
mainfrom
chore/extend-respect-event

Conversation

@DmitryAnansky
Copy link
Copy Markdown
Contributor

@DmitryAnansky DmitryAnansky commented May 15, 2026

What/Why/How?

Extended respect event with additional fields

Reference

https://github.com/Redocly/redocly/pull/23264

Testing

Screenshots (optional)

Check yourself

  • This PR follows the contributing guide
  • All new/updated code is covered by tests
  • Core code changed? - Tested with other Redocly products (internal contributions only)
  • New package installed? - Tested in different environments (browser/node)
  • Documentation update has been considered

Security

  • The security impact of the change has been considered
  • Code follows company security practices and guidelines

Note

Low Risk
Low risk: this only adds two new optional telemetry fields for arazzo1 specs and does not change command execution behavior beyond extra data collection/serialization.

Overview
Extends the CLI telemetry (respect event) for arazzo1 specs to also report respect_source_description_types (unique sourceDescriptions[].type) and respect_criterion_object_types (unique criterion type values gathered from workflow/step/actions and reusable components).

Updates commandWrapper to collect these values during spec parsing and passes them to sendTelemetry, which conditionally serializes them into the emitted event. Adds unit tests covering the new collectors and the updated telemetry payload shape.

Reviewed by Cursor Bugbot for commit 87e6754. Bugbot is set up for automated code reviews on this repo. Configure here.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 15, 2026

⚠️ No Changeset found

Latest commit: 87e6754

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

CLI Version Mean Time ± Std Dev (s) Relative Performance (Lower is Faster)
cli-latest 1.999s ± 0.038s ▓ 1.00x (Fastest)
cli-next 2.002s ± 0.031s ▓ 1.00x

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 80.73% (🎯 80%) 7218 / 8940
🔵 Statements 80.12% (🎯 80%) 7498 / 9358
🔵 Functions 83.74% (🎯 83%) 1443 / 1723
🔵 Branches 72.39% (🎯 72%) 4915 / 6789
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
packages/cli/src/wrapper.ts 75.6% 44.11% 100% 75% 50, 68, 72-80, 98-105
packages/cli/src/utils/telemetry.ts 92.64% 75.96% 95% 93.23% 59, 64, 247, 283, 296-297, 341, 372, 377
Generated in workflow #9835 for commit 87e6754 by the Vitest Coverage Report Action

@DmitryAnansky DmitryAnansky marked this pull request as ready for review May 15, 2026 15:54
@DmitryAnansky DmitryAnansky requested review from a team as code owners May 15, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant