fix: do not assume schemas containing allOf are being used in discriminator#2817
Draft
tatomyr wants to merge 1 commit into
Draft
fix: do not assume schemas containing allOf are being used in discriminator#2817tatomyr wants to merge 1 commit into
tatomyr wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: cafc910 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tatomyr
commented
May 14, 2026
|
|
||
| beforeEach(() => { | ||
| releaseAjvInstance(); | ||
| vi.clearAllMocks(); |
Collaborator
Author
There was a problem hiding this comment.
Unrelated. Just cleaning up.
Contributor
|
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
tatomyr
commented
May 14, 2026
| NamedSchemas: { | ||
| Schema(schema, { location, key }) { | ||
| if (!schema.allOf) { | ||
| // FIXME: find a better way to detect possible discriminator |
Collaborator
Author
There was a problem hiding this comment.
It is getting resolved by discriminator mapping, which is being treated as $refs, so the components are properly recognized as used when they are referenced in discriminator mapping.
tatomyr
force-pushed
the
fix/unused-components
branch
from
62c8dba to
cafc910
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Fixed the
no-unused-componentsrule to highlight unused schemas containingallOfkeyword.Reference
Related: #1209 (comment).
Testing
Screenshots (optional)
Check yourself
Security