HMS-9826: add typescript config, migrate small component to TS#1535
Open
xbhouse wants to merge 5 commits intoRedHatInsights:masterfrom
Open
HMS-9826: add typescript config, migrate small component to TS#1535xbhouse wants to merge 5 commits intoRedHatInsights:masterfrom
xbhouse wants to merge 5 commits intoRedHatInsights:masterfrom
Conversation
- move vulnerability api to separate file for easier migration - update imports
- move actions specific to cves to separate file for easier migration - convert cve store and test to ts - add typed hooks to use in components
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1535 +/- ##
==========================================
+ Coverage 73.67% 77.81% +4.14%
==========================================
Files 97 102 +5
Lines 2359 3070 +711
Branches 666 666
==========================================
+ Hits 1738 2389 +651
- Misses 551 615 +64
+ Partials 70 66 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Associated Jira ticket: HMS-9826
This PR adds initial Typescript support and migrates the CvesModal SmartComponent as a first example
noImplicitAnyoption in the tsconfig tofalseto ease the initial migration, but we should still aim to define types when it's possibleHow to test the PR
Before the change
After the change
Dependent work link
Checklist: