Skip to content

RHINENG-16026: tweak Kessel logs #2100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dugowitch wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RHINENG-16026: tweak Kessel logs #2100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions manager/middlewares/kessel.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,17 +83,17 @@ func useStreamedListObjects(
) {
if err != nil {
utils.LogError(
"err", err.Error(), "receivingDuration", time.Since(start), "permission", permission, "received_count",
len(workspaces), "failed to useStreamedListObjects",
"err", err.Error(), "durationMs", time.Since(start).Nanoseconds()/1e6, "permission", permission,
Copy link
Collaborator

@MichaelMraka MichaelMraka Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As suggested by sourcery: time.Since(start).Milliseconds() would be better / more readable :) .

"received_count", len(workspaces), "failed to useStreamedListObjects",
)
return nil, err
}
workspaces = append(workspaces, res)
}

utils.LogDebug(
"workspaces", workspaces, "receivingDuration", time.Since(start), "permission", permission, "received_count",
len(workspaces), "retrieved workspaces",
"durationMs", time.Since(start).Nanoseconds()/1e6, "permission", permission, "received_count", len(workspaces),
"retrieved workspaces",
)
return workspaces, nil
}
Expand Down Expand Up @@ -136,7 +136,6 @@ func hasPermissionKessel(c *gin.Context) {
return
}
c.Set(utils.KeyInventoryGroups, inventoryGroups)
utils.LogDebug("Kessel check OK")
}

func Kessel() gin.HandlerFunc {
Expand Down
Loading