Guard Microsoft Update Catalog row parsing against null table cells

[Copilot]

Deploying with Deploy-OSDCloud -CLI could emit You cannot call a method on a null-value expression during Microsoft Update Catalog driver lookups. The failure path was triggered by unexpected/malformed catalog rows being parsed without null checks.

• Root cause

  • Get-MicrosoftUpdateCatalogResult assumed every row had expected <td> nodes and called .InnerText.Trim() directly.

• Code changes

  • Added defensive cell extraction in base filtering:
    • Skip rows when SelectNodes("td") is null or has fewer than required cells.
    • Read fields via safe string casts instead of direct method calls on potentially null values.
  • Added the same guard in architecture filtering to avoid null access on sparse rows.

• Behavioral impact

  • Malformed/incomplete catalog rows are ignored instead of surfacing runtime null-method warnings.
  • Existing filtering behavior for valid rows is unchanged.

$cells = $_.SelectNodes("td")
if ($null -eq $cells -or $cells.Count -lt 4) {
    return $false
}

$title = [string]$cells[1].InnerText
$classification = [string]$cells[3].InnerText

• Fixes Warning: You cannot call a method on a null-value expression #19

[Copilot]

Copilot review overview

🟡 Changes recommended

Incomplete rows can still reach object construction, and classification whitespace handling regresses.

Review effort: Balanced
Findings: 2

Open (2)

• Require eight cells before processing update rows · New
• Trim update classification before applying exact filters · New

What changed in this PR

Hardens Microsoft Update Catalog parsing against malformed rows during driver lookup.

Changes:

• Adds cell-count guards during base and architecture filtering.
• Uses null-safe string conversion for extracted fields.

File	Description
OSDCloud/​private/​microsoft-update-catalog/​Get-MicrosoftUpdateCatalogResult.ps1	Adds defensive catalog-row parsing.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.