Conversation
…drift The "Install to Agent" mock card on the marketplace preview step was missing OpenCode because PR #36 didn't update an inline hardcoded agent list. Three agent enumerations in this file were duplicated from AGENT_ORDER, so any future agent addition could silently drift again. - Drop the local AGENTS const and inline {id,label} lists; derive all three sites from AGENT_ORDER + agentDisplayName(). - Re-key FLOAT_DELAYS and SCATTER_POSITIONS as Record<(typeof AGENT_ORDER)[number], ...> so adding an agent forces TS to flag missing entries rather than producing undefined at runtime. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AGENT_ORDER+agentDisplayName()so future agent additions can't silently drift again.FLOAT_DELAYS/SCATTER_POSITIONSasRecord<(typeof AGENT_ORDER)[number], ...>— adding a 9th agent now produces a hardtscerror (TS2741: Property '<name>' is missing) instead of a runtimeundefinedon the scatter animation.Test plan
npx tsc --noEmitcleannpm run lintcleanFLOAT_DELAYSyieldsTS2741🤖 Generated with Claude Code