new components for currency exchange#172
Open
Akashdeep-Patra wants to merge 5 commits into
Open
Conversation
Akashdeep-Patra
changed the title
swarajpure
reviewed
Mar 14, 2021
swarajpure
left a comment
swarajpure
left a comment
Contributor
There was a problem hiding this comment.
Some queries.. please check...
Nice PR btw 😂
| second_image, | ||
| normalized_number, | ||
| }) => { | ||
| const ExcgangeRateRow = ({ src, target, value }) => { |
Contributor
There was a problem hiding this comment.
I guess you meant ExchangeRateRow... The spelling of Exchange...
| display: flex; | ||
| justify-content: space-between; | ||
| column-gap: 2%; | ||
| padding: 5%; |
Contributor
There was a problem hiding this comment.
Are we sure to keep the padding dynamic? 🤔
| column-gap: 2%; | ||
| } | ||
| .currency_exchange_select__component { | ||
| height: 50px !important; |
Contributor
There was a problem hiding this comment.
!important.... Can we have some other fix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.