feat: capitalize first character in create new group text field#1251
Open
codacy20 wants to merge 1 commit intoReadYouApp:mainfrom
Open
feat: capitalize first character in create new group text field#1251codacy20 wants to merge 1 commit intoReadYouApp:mainfrom
codacy20 wants to merge 1 commit intoReadYouApp:mainfrom
Conversation
Author
|
@JunkFood02 mind reviewing this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary: Auto-capitalize first character in "Create New Group" text field
Problem
When tapping the
+button under "Move to Group" to create a new group/category, the keyboard appeared without sentence capitalization — the user had to manually capitalize the first letter of the group name.Root Cause
ClipboardTextField was building
KeyboardOptionswith onlyimeActionset, leavingcapitalizationunspecified (defaults toKeyboardCapitalization.None). This propagated all the way down to theTextFieldcomposable shown in the dialog.Changes
ClipboardTextField.kt — Added a
capitalization: KeyboardCapitalizationparameter (defaultNone) and wired it into theKeyboardOptionspassed to RYTextField2. This keeps the change opt-in and non-breaking for all existing callers (e.g. URL fields).TextFieldDialog.kt — Added a
capitalizationparameter (defaultNone) to the deprecatedString-based overload and forwarded it to ClipboardTextField.FeedOptionDrawer.kt — Passes
KeyboardCapitalization.Sentencesto the "Create New Group" TextFieldDialog, so the keyboard auto-capitalizes the first letter when opening the dialog from the feed options drawer.SubscribeDialog.kt — Same fix applied to the "Create New Group" TextFieldDialog in the subscribe/add feed flow.
Scope
Only the two group-name entry dialogs are affected. All other ClipboardTextField usages (feed URL input, etc.) retain
KeyboardCapitalization.Nonesince nocapitalizationargument is passed.