use pytest in CI, and exclude tests from coverage again#301
Open
joanise wants to merge 5 commits intodev.ej/picky-codingfrom
Open
use pytest in CI, and exclude tests from coverage again#301joanise wants to merge 5 commits intodev.ej/picky-codingfrom
joanise wants to merge 5 commits intodev.ej/picky-codingfrom
Conversation
Changed Files
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev.ej/picky-coding #301 +/- ##
=======================================================
- Coverage 95.70% 93.76% -1.94%
=======================================================
Files 43 21 -22
Lines 3632 1765 -1867
Branches 0 295 +295
=======================================================
- Hits 3476 1655 -1821
+ Misses 156 73 -83
- Partials 0 37 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
00f4bec to
57fc1aa
Compare
Member
Author
|
@dhdaines Adding you to reviewers here because you might be happy to see the move fully to pytest, in CI, in I have not started using fixtures for Studio, but I have one fixture in g2p (to launch g2p_studio). A number of tests in Studio could be simplified with fixtures, but that's going to stay lower priority at the moment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
In previous refactorings, we accidentally started counting coverage of
tests/*again. Reconfigure that out.And let's use pytest in CI too, it's now required and the default, so we can start embracing it.
Confidence?
high