Skip to content

use pytest in CI, and exclude tests from coverage again#301

Open
joanise wants to merge 5 commits intodev.ej/picky-codingfrom
dev.ej/pytest-ci
Open

use pytest in CI, and exclude tests from coverage again#301
joanise wants to merge 5 commits intodev.ej/picky-codingfrom
dev.ej/pytest-ci

Conversation

@joanise
Copy link
Copy Markdown
Member

@joanise joanise commented Apr 21, 2026

PR Goal?

In previous refactorings, we accidentally started counting coverage of tests/* again. Reconfigure that out.

And let's use pytest in CI too, it's now required and the default, so we can start embracing it.

Confidence?

high

@semanticdiff-com
Copy link
Copy Markdown

semanticdiff-com Bot commented Apr 21, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  tests/test_anchors.py  48% smaller
  tests/test_audio.py  48% smaller
  tests/test_make_xml_cli.py  48% smaller
  tests/test_smil.py  48% smaller
  tests/test_tokenize_cli.py  48% smaller
  tests/test_dna_utils.py  48% smaller
  tests/test_force_align.py  23% smaller
  .github/workflows/tests.yml  18% smaller
  tests/test_temp_file.py  17% smaller
  run_tests.py  11% smaller
  pyproject.toml Unsupported file format
  tests/.coveragerc Unsupported file format
  tests/test_align_cli.py  0% smaller
  tests/test_api.py  0% smaller
  tests/test_config.py  0% smaller
  tests/test_dna_text.py  0% smaller
  tests/test_dtd.py  0% smaller
  tests/test_g2p_cli.py  0% smaller
  tests/test_misc.py  0% smaller
  tests/test_package_urls.py  0% smaller
  tests/test_silence.py  0% smaller
  tests/test_tokenize_xml.py  0% smaller
  tests/test_web_api.py  0% smaller

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.76%. Comparing base (9b9af60) to head (b4b4054).

Additional details and impacted files
@@                   Coverage Diff                   @@
##           dev.ej/picky-coding     #301      +/-   ##
=======================================================
- Coverage                95.70%   93.76%   -1.94%     
=======================================================
  Files                       43       21      -22     
  Lines                     3632     1765    -1867     
  Branches                     0      295     +295     
=======================================================
- Hits                      3476     1655    -1821     
+ Misses                     156       73      -83     
- Partials                     0       37      +37     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026

CLI load time: 0:00.04
Pull Request HEAD: b4b40542dba0a8d6b27cfab00f65906fcc67fe1e
No imports take more than 0.1 s.

@joanise
Copy link
Copy Markdown
Member Author

joanise commented Apr 21, 2026

@dhdaines Adding you to reviewers here because you might be happy to see the move fully to pytest, in CI, in run_tests.py, everywhere.

I have not started using fixtures for Studio, but I have one fixture in g2p (to launch g2p_studio). A number of tests in Studio could be simplified with fixtures, but that's going to stay lower priority at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant