Open
Conversation
Suggested by ruff/pyupgrade (UP020): https://docs.astral.sh/ruff/rules/open-alias/ io.open was needed in Python 2.6/2.7, just an alias of builtin open in Python 3.
Ran uvx ruff check --select UP --fix which applied the safe recommendations automatically.
Changed Files
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #300 +/- ##
==========================================
+ Coverage 95.20% 95.70% +0.49%
==========================================
Files 43 43
Lines 3674 3632 -42
==========================================
- Hits 3498 3476 -22
+ Misses 176 156 -20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Actually, the real goal is to push an update to main so that heroku integration, which was just cycled, gets exercised.
The changes applied are all things that are no longer needed with recent versions of python:
"{}".format()instead of f-strings__future__imports where that future is now-*- coding: utf-8 -*-Also remove some dead code from
utils.pyflagged by codecov. That code was long-since unused.Fixes?
picky details fixed by
uvx ruff check --select UP --fixand a few manual fixups afterFeedback sought?
rubber stamping
Confidence?
high