Merged
Conversation
Changed Files
|
Contributor
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #299 +/- ##
=======================================
Coverage 95.20% 95.20%
=======================================
Files 43 43
Lines 3673 3674 +1
=======================================
+ Hits 3497 3498 +1
Misses 176 176 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stderr is no longer mixed with stdout, but it is always included in result.output with old and new versions of click
a32af68 to
e8fd924
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Goal?
Clean up dependencies
It was not hard to adapt the Studio to more recent versions of click:
results.stdout + results.stderrresults.output instead of just results.stdout; doing soin a try catch lets me remainis compatible with old and new versions--configoption toaligna default value ofNoneso that we don't get click's newSentinel.UNSETvalue now provided with an option with an argument but no default is not specified by the user.Fixes?
Unnecessary lockage of dependencies in the past
Also disable silencing C stderr when running with Pytest: a) pytest already captures all output, and b) doing so again under pytest's feet breaks things.
Feedback sought?
sanity checking
Priority?
low
Tests added?
well covered by CI
How to test?
In a g2p sandbox, checkout and install NRC-ILT/g2p#485:
In a Studio sandbox, checkout and install this PR, in the same venv you ran that g2p install in
Then run the tests as you usually do, e.g.:
I also have branch
dev.ej/misc-deps-cleanupwhich sets the g2p dependency on github@dev.ej/relax-click, so you can test on that branch. And I ran Matrix testing on that branch: see https://github.com/ReadAlongs/Studio/actions/runs/24367223612Confidence?
high
Version change?
Yes, I plan to release a patch to publish these relaxed dependencies.