This repository was archived by the owner on Jun 7, 2024. It is now read-only.
number of plog rates written to pdepnetworks set to fame default#254
Open
nickvandewiele wants to merge 1 commit intoReactionMechanismGenerator:masterfrom
Open
number of plog rates written to pdepnetworks set to fame default#254nickvandewiele wants to merge 1 commit intoReactionMechanismGenerator:masterfrom
nickvandewiele wants to merge 1 commit intoReactionMechanismGenerator:masterfrom
Conversation
For now, the phrase "Could be different for seed and library reactions, but default for FAME-generated rates is probably " that was written to pdepnetworks.txt in the restart folder is replaced by the FAME default number of PLOGS. WARNING: this is a temporary solution that (almost) certainly works in absence of seed mechanisms and PKLs, PRLs but certainly fails in presence of the latter. Check Github issue threads for more information. Tested successfully on the 1,3-Hexadiene example.
Member
|
Does this break the use of PLOG in Seed Mechanisms? eg. try Glarborg/C2 as a seed. |
Contributor
Author
|
One of the species in Glarborg is forbidden, for a reason unknown to me. I will try another seed mech. |
Member
|
The error message (and documentation) have just been improved (as of this morning, see issue #249): you need to add a primary thermo library that contains the relevant species, eg. DFT_QCI_thermo |
Contributor
Author
|
running the 13HXD example with read restart (i.e. run the example without seed mech, then rerun it with seed mech and increase error tolerance), P-Dep activated, and Glarborg/C2 as a seed mech seems to run fine. That is after 8bff713. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, the phrase
"Could be different for seed and library reactions,
but default for FAME-generated rates is probably "
that was written to pdepnetworks.txt in the restart folder is replaced
by the FAME default number of PLOGS.
WARNING: this is a temporary solution that (almost) certainly
works in absence of seed mechanisms and PKLs, PRLs but certainly
fails in presence of the latter. Check Github issue threads for more
information.
Tested successfully on the 1,3-Hexadiene example.