Fix col.names="none" suppressing all output when row.names=FALSE #7804
Open
venom1204 wants to merge 4 commits into
Open
Fix col.names="none" suppressing all output when row.names=FALSE #7804venom1204 wants to merge 4 commits into
venom1204 wants to merge 4 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7804 +/- ##
=======================================
Coverage 99.01% 99.01%
=======================================
Files 88 88
Lines 17219 17226 +7
=======================================
+ Hits 17050 17057 +7
Misses 169 169 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Generated via commit 56acefc Download link for the artifact containing the test results: ↓ atime-results.zip
|
Member
|
thanks. |
Contributor
Author
hi i just updated the pr description and added the news entry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7735
the PR fixes a bug where setting
col.names="none"combined withrow.names=FALSEresulted in zero output.Before:
col.names="none"+row.names=FALSEresulted in blank output because the internal regex required row markers (e.g., 1:) to identify lines to keep.After:
When row names are suppressed, the header is now dropped by position instead of pattern, ensuring data rows print correctly.