-
Notifications
You must be signed in to change notification settings - Fork 1k
Bump master to 1.18.99 #7513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump master to 1.18.99 #7513
Conversation
MichaelChirico
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Be sure to add the tag for 1.18.0 as well
|
Thanks, I did tag it but it isn't showing up on GitHub. Investigating why, will redo if necessary. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7513 +/- ##
==========================================
- Coverage 99.04% 98.97% -0.07%
==========================================
Files 87 87
Lines 16707 16740 +33
==========================================
+ Hits 16547 16568 +21
- Misses 160 172 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Generated via commit 8073130 Download link for the artifact containing the test results: ↓ atime-results.zip
|
aitap
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 1.18.0 tag is visible now.
|
|
||
| #: assign.c:326 | ||
| #, c-format | ||
| msgid "Added %d new column initialized with all-NA\n" | ||
| msgstr "" | ||
|
|
||
| #: assign.c:332 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be missing the singular forms of the translated messages from the Pl_ macro. @MichaelChirico, what's the right xgettext call to capture them?
| {NULL, NULL, 0} | ||
| }; | ||
| static const R_CallMethodDef callMethods[] = { | ||
| {"Csetattrib", (DL_FUNC)&setattrib, -1}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you apply a C source formatter or perform the changes manually?

Now that
1.18.0is on CRAN, we are bumping master to1.18.99.