Skip to content

Conversation

@ben-schwen
Copy link
Member

@ben-schwen ben-schwen commented Dec 23, 2025

Follows #7500
Closes #7507

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.04%. Comparing base (ba7a1b3) to head (7a73e19).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7508   +/-   ##
=======================================
  Coverage   99.04%   99.04%           
=======================================
  Files          87       87           
  Lines       16704    16706    +2     
=======================================
+ Hits        16544    16546    +2     
  Misses        160      160           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@aitap aitap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it does happen after all. LGTM, thanks!

@ben-schwen
Copy link
Member Author

So it does happen after all. LGTM, thanks!

Yes and R6 classes is a common enough case to not ignore it!

@ben-schwen ben-schwen merged commit 931e8e2 into master Dec 23, 2025
12 checks passed
@ben-schwen ben-schwen deleted the set_delete_subexpression branch December 23, 2025 15:58
@github-actions
Copy link

No obvious timing issues in HEAD=set_delete_subexpression
Comparison Plot

Generated via commit 7a73e19

Download link for the artifact containing the test results: ↓ atime-results.zip

Task Duration
R setup and installing dependencies 5 minutes and 9 seconds
Installing different package versions 11 minutes and 49 seconds
Running and plotting the test cases 5 minutes and 9 seconds

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

revdep irace set on R6 class

2 participants