Skip to content

fix(system): reject boolean timeit arguments #614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
belowzeroff wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(system): reject boolean timeit arguments #614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/lang/syscmd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ static int64_t arg_as_i64(ray_t* arg, int* err) {
if (arg->type == -RAY_I32) return (int64_t)arg->i32;
if (arg->type == -RAY_I16) return (int64_t)arg->i16;
if (arg->type == -RAY_U8) return (int64_t)arg->u8;
if (arg->type == -RAY_BOOL) return (int64_t)arg->b8;
if (arg->type == -RAY_STR) {
const char* p = ray_str_ptr(arg);
size_t len = ray_str_len(arg);
Expand Down
10 changes: 5 additions & 5 deletions test/rfl/system/syscmd_coverage.rfl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
(.sys.cmd "rm -f /tmp/rfl_syscmd_cov*") -- 0

;; ────────────── arg_as_i64: typed-int branches via .sys.timeit ──────────────
;; Each non-string integer kind takes a distinct early-return path in
;; Each supported non-string integer kind takes a distinct early-return path in
;; arg_as_i64 (lines 68-72). Driving them through .sys.timeit is the
;; cleanest way to round-trip the result back into Rayfall.
(.sys.timeit 1) -- 1
Expand All @@ -40,8 +40,8 @@
(.sys.timeit 0h) -- 0
(.sys.timeit 0x01) -- 1
(.sys.timeit 0x00) -- 0
(.sys.timeit true) -- 1
(.sys.timeit false) -- 0
(.sys.timeit true) !- type
(.sys.timeit false) !- type

;; ────────────── arg_as_i64: STR branches via .sys.cmd dispatch ──────────────
;; The string parser handles leading whitespace, optional sign, then
Expand Down Expand Up @@ -69,7 +69,7 @@
;; arg_as_i64 has an explicit early-return for every integer kind plus
;; STR; any other typed arg falls past all branches into the final
;; `*err = 1; return 0;` pair (lines 85-86). Reaching it requires a
;; non-null, non-int, non-bool, non-string atom routed past the
;; non-null, non-integer, non-string atom routed past the
;; string-dispatch guard — i.e. a direct `.sys.timeit` / `.sys.listen`
;; call with a typed atom (float, sym, etc.). The handler then sees
;; err=1 and returns "type". These probes are the only path from rfl
Expand All @@ -94,7 +94,7 @@
(.sys.timeit 0) -- 0

;; ────────────── arg_as_i64: type-fallthrough (lines 85-86) ──────────
;; Float atoms hit the final *err=1; return 0 branch — neither I64/I32/I16/U8/BOOL
;; Float atoms hit the final *err=1; return 0 branch — neither I64/I32/I16/U8
;; nor STR. Only reachable via direct `.sys.timeit`/`.sys.listen` calls
;; (the .sys.cmd dispatcher always wraps args as strings).
(.sys.timeit 1.5) !- type
Expand Down
Loading