Fix submitted projects n plus 1#794
Draft
zetter-rpf wants to merge 2 commits intomainfrom
Draft
Conversation
Note that you will need to have asdf on your non-interactive shell path for this to work. If you see a bunder not installed message this is likely the cause. You can fix this by making sure asdf is added to your path in your zprofile instead of your zshrc. I've added the rspec bin stub as part of this as it's quicker than typing bundle exec and simpler than using it in the tasks.json
zetter-rpf
force-pushed
the
fix-submitted-projects-n-plus-1
branch
from
d4a395d to
d0c2a49
Compare
Test coverage89.41% line coverage reported by SimpleCov. |
zetter-rpf
force-pushed
the
fix-submitted-projects-n-plus-1
branch
2 times, most recently
from
ebd5795 to
4080188
Compare
While we have bullet, but it wasn't failing because there wasn't enough test data set up. Since the extra includes is only used by teachers, I've had to change the controller action around bit. Newer version of rails have a 'strict_loading' mode which can help prevent N+1 queries, however I don't want to introduce it until after we upgrade to rails 8 and can configure the 'strict_loading_mode' to only n+1 queries otherwise there is a lot of noise from single queries[1]. [1] - https://thoughtbot.com/blog/strict-loading-in-rails-8-a-railsy-way-to-avoid-n-1-queries
zetter-rpf
force-pushed
the
fix-submitted-projects-n-plus-1
branch
from
4080188 to
0a46ba4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Points for consideration:
What's changed?
Description of what's been done - bullets are often best
Steps to perform after deploying to production
If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, a migration, or upgrading a Gem. That kind of thing.