Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The email may be sent before roles are transferred and contains hardcoded production links.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds a confirmation email for nominees after an ownership transfer completes.
Changes:
- Adds completion-email delivery and content.
- Adds model and mailer specs plus a preview.
- Includes owner guidance and Help Center links.
| File | Summary |
|---|---|
spec/models/ownership_transfer_spec.rb |
Tests completion callback behavior. |
spec/mailers/school_ownership_mailer_spec.rb |
Tests recipients and email content. |
spec/mailers/previews/school_ownership_mailer_preview.rb |
Adds a completion-email preview. |
app/views/school_ownership_mailer/complete_ownership_transfer.text.erb |
Defines the confirmation email; links require environment-specific hosts. |
app/models/ownership_transfer.rb |
Adds completion-email delivery; role transfer must occur before sending. |
app/mailers/school_ownership_mailer.rb |
Builds the new-owner confirmation email. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Test coverage93.69% line coverage reported by SimpleCov. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Issue#1769 - sends the new owner a confirmation email once an ownership transfer completes.
What this does
Why
Gives the new owner a clear record that the transfer went through, rather than them just finding out by noticing they now have owner access.