Make themes tabs on the landing page - #6
Merged
Merged
Conversation
Onboarding and Importing projects were stacked sections, so finding a prototype meant scrolling past every lane of the theme you were not looking at. They are tabs now: one theme's lanes on the page at a time, with the count of prototypes behind each tab so the unselected theme is not a closed door. The selected theme lives in the query string (#/?theme=importing-projects) for the same reason prototypes are deep-linkable — you can send someone a link that opens where you are. Drops the "Jump to a lane" box. It was built for a page running several screens; the tabs now do that job and carry the counts, so keeping both was two navigation systems for one short page. The lane headings lose the tabIndex and focus styles that only existed to receive focus from it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Onboarding and Importing projects were stacked sections, so finding a prototype meant scrolling past every lane of the theme you were not looking at. They are tabs now: one theme's lanes on the page at a time, with the count of prototypes behind each tab so the unselected theme is not a closed door.
The selected theme lives in the query string (#/?theme=importing-projects) for the same reason prototypes are deep-linkable — you can send someone a link that opens where you are.
Drops the "Jump to a lane" box. It was built for a page running several screens; the tabs now do that job and carry the counts, so keeping both was two navigation systems for one short page. The lane headings lose the tabIndex and focus styles that only existed to receive focus from it.
What you're trying
One sentence. Which lane, and what approach.
What you believe
The hypothesis from your
meta.ts— what a testing session could disprove.What to look at
A link, once this has a preview or is merged. Add
?full=1&autofill=0if youwant someone to see it the way a tester would.
What you'd like feedback on
The bit you are least sure about is usually the most useful thing to name.
notes.md