Chore/modal width and remove samples - #5
Merged
Merged
Conversation
The design system's modal is as wide as the viewport allows (calc(100vw - 2 * --space-10)), which suits almost nothing here: every dialog in this repo is a short question or a small form, and a question stretched across a large monitor reads as a page that has gone wrong. Set as a repo default rather than copied per prototype. Two prototypes had already reached for the same --rpf-modal-max-inline-size override and the kit gallery wanted it too, so the alternative was everybody rediscovering the lever -- and it means import-yp gets a sane dialog without this reaching into another prototype's folder. out-to-projects-and-back drops its local copy. The design system only applies this above 30rem; below that a separate mobile variable keeps a dialog near full width, which is right on a phone. Checked at 375px: unchanged there. Also excludes dialogs from the kit gallery's `.demo-stage > *` overflow guard. That guard was flattening the modal demo to the stage width, so with everything else narrowed the gallery would have advertised modals at twice the width they ever render. The guard still applies to form inputs and the rest. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`onboarding-mentor/reference-manage-club-route` and
`onboarding-yp/reference-school-code-join` were scaffolding — sample ideas to
show the shape of a prototype until designers started building real ones.
That has happened, so they go.
They turned out to be load-bearing in the docs, which is the part worth
knowing. Five references repointed:
- README.md listed both as the worked examples to copy from. Now points at
import-mentor/start-on-projects and import-yp/browse-projects-in-classroom,
one per audience.
- SETUP.md and src/prototypes/README.md used the school-code one in the
?full=1&autofill=0 example URL. Repointed to
import-yp/browse-projects-in-classroom, which still has a school-code
sign-in — so the surrounding text about watching someone type a six-digit
code still means what it says.
- The /new-prototype skill and _template/prototype.tsx both cited it as *the*
worked example for deriving from the cast. Anyone running the skill would
have been sent to a folder that no longer exists. Repointed to the same
replacement, which uses that exact pattern.
Left alone deliberately: dashboard-primary-action/notes.md references
reference-manage-club-route twice, once as a testing instruction ("run it
against ... with different mentors"). That is design reasoning about a
comparison that no longer exists, and deciding what the prototype is for now
is its owner's call, not a find-and-replace.
onboarding-yp is now empty and shows "No prototypes yet", which lanes.ts
says doubles as a visible to-do list.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What you're trying
One sentence. Which lane, and what approach.
What you believe
The hypothesis from your
meta.ts— what a testing session could disprove.What to look at
A link, once this has a preview or is merged. Add
?full=1&autofill=0if youwant someone to see it the way a tester would.
What you'd like feedback on
The bit you are least sure about is usually the most useful thing to name.
notes.md