Skip to content

fix: Block-level ARIA labels no longer include clickable image descri… #9844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lizschwab wants to merge 1 commit into
base: v13
Choose a base branch
from
Draft

fix: Block-level ARIA labels no longer include clickable image descri… #9844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/blockly/core/field_image.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,6 +315,13 @@
return this.altText || null;
}

override computeAriaLabel(includeTypeInfo: boolean): string {
if (this.isClickable()) {
return '';
}
return super.computeAriaLabel(includeTypeInfo);
}

/**
* Recomputes the ARIA role and label for this field.
*/
Expand All @@ -338,7 +345,7 @@
this.isClickable() ? aria.Role.BUTTON : aria.Role.PRESENTATION,
);

const label = this.computeAriaLabel(true);
const label = this.isClickable() ? this.getAriaValue() || '' : super.computeAriaLabel(true);

Check failure on line 348 in packages/blockly/core/field_image.ts

View workflow job for this annotation

GitHub Actions / lint 

Replace `·?·this.getAriaValue()·||·''` with `⏎······?·this.getAriaValue()·||·''⏎·····`
aria.setState(focusableElement, aria.State.LABEL, label);
}
}
Expand Down
Loading