Skip to content

fix: Update workspace ARIA label on focus #9841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gonfunko wants to merge 1 commit into
base: v13
Choose a base branch
from
+6 −10
Open

fix: Update workspace ARIA label on focus #9841

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions packages/blockly/core/workspace_svg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ export class WorkspaceSvg
);
} else {
// Main workspaces get labelled with how many stacks of blocks they contain
// This will be updated in a change listener, but set it here in case there are blocks in the initial state of the workspace
// This will be updated on focus, but set it here in case there are blocks in the initial state of the workspace
this.updateAriaLabel();
}
}
Expand Down Expand Up @@ -798,14 +798,6 @@ export class WorkspaceSvg

this.setInitialAriaContext();

if (!this.isFlyout && !this.isMutator) {
// Set up a change listener to update the aria label on main workspace
this.addChangeListener((e) => {
if (e.isUiEvent) return;
this.updateAriaLabel();
});
}

if (!this.isFlyout) {
browserEvents.conditionalBind(
this.svgGroup_,
Expand Down Expand Up @@ -2696,7 +2688,11 @@ export class WorkspaceSvg
}

/** See IFocusableNode.onNodeFocus. */
onNodeFocus(): void {}
onNodeFocus(): void {
if (!this.isFlyout && !this.isMutator) {
this.updateAriaLabel();
}
}

/** See IFocusableNode.onNodeBlur. */
onNodeBlur(): void {}
Expand Down
Loading