Skip to content

Tighten PHPCS and improve CI#70

Merged
tommitchelmore merged 18 commits into
masterfrom
feature/improve-ci
May 12, 2026
Merged

Tighten PHPCS and improve CI#70
tommitchelmore merged 18 commits into
masterfrom
feature/improve-ci

Conversation

@tommitchelmore
Copy link
Copy Markdown
Collaborator

@tommitchelmore tommitchelmore commented May 7, 2026

CI Overhaul

This PR introduces a large overhaul to our CI pipeline, to tighten it up and improve DX going forwards.

CI Changes

  • Scoped push events to master and added a concurrency group with cancel-in-progress: true to prevent redundant builds.
  • Explicitly restricted job permissions to contents: read.
  • Refactored the strategy matrix to use dependency_type (stable vs. lowest) and disabled fail-fast to ensure complete tests across all versions which is helpful for debugging.
  • Migrated from php-actions/composer action to direct composer update CLI calls, saves a redundant docker container being spun up
  • Replaced deprecated/commented Coveralls logic with CodeCoverageSummary, injecting a markdown report directly into the GitHub Job Summary (restricted to PHP 8.3 stable builds).

Code changes

  • Tightened PHPCS
  • Fixed all codestyle issues

Future work

We have made a note to add in PHPStan/similar in a future major release. This is because a full static analysis pass will result in a lot of breaking changes.

@tommitchelmore tommitchelmore marked this pull request as draft May 7, 2026 09:19
@tommitchelmore tommitchelmore self-assigned this May 8, 2026
@tommitchelmore tommitchelmore added this to the v8.3.0 milestone May 8, 2026
@tommitchelmore tommitchelmore marked this pull request as ready for review May 12, 2026 08:07
@Rareloop Rareloop deleted a comment from github-actions Bot May 12, 2026
@tommitchelmore tommitchelmore merged commit a91eeb7 into master May 12, 2026
6 checks passed
@tommitchelmore tommitchelmore deleted the feature/improve-ci branch May 12, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants