Conversation
|
@LinoGiger can you please look into why this is constantly failing and either close or merge this pr |
80dfdb8 to
45a9ea1
Compare
⚠ Agent skill not updatedThis PR does not modify Before merging, pick one:
|
|
Status after rebasing onto The only red check is the new Agent Skill gate from #911. It isn't a code failure: it fails for any PR that leaves → Reviewer: please add |
Constructing any LoggingConfig pushed its settings to the global tracer and logger, so a standalone LoggingConfig(enable_otlp=True) re-enabled OTLP for the whole process. Only the global rapidata_config.logging now notifies the handlers; the conftest resync from #913 stays as a test-side backstop. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: luca@rapidata.ai <25279790+LucStr@users.noreply.github.com>
45a9ea1 to
211285d
Compare
|
Rebased again, this time onto #913. #913 added a The PR is now the source fix plus its regression test: only |
Problem
Most
Rapidata.Python.SDKerror spans in prod come from our own test runs: ~94% of the 1,665 SDK error spans in the last 7 days carryMagicMock,job-1/My Jobfixtures, or runner/vessel kernels. They hide real customer errors. The versions sending them (3.25.5–3.25.7) already include #867, which disabled OTLP under pytest.Root cause:
LoggingConfig.__init__called_notify_handlers(), so anyLoggingConfiginstance reconfigured the global tracer and logger.test_explicit_true_overrides_the_pytest_defaultbuildsLoggingConfig(enable_otlp=True), and every test after it exported tootlp-sdk.rapidata.ai.Fix
LoggingConfig.__init__;rapidata_config.pynotifies once for the globalrapidata_config.logging. Attribute updates on the global (the documented API,rapidata_config.logging.x = …) still propagate through__setattr__.tests/conftest.py: an autouse fixture resetsenable_otlpafter each test, so no single test can leak tracing into the rest of the run.LoggingConfig(enable_otlp=True)leaves the global tracer disabled.Verification
pytest_sessionfinishprobe of the global tracer: onmainit endsenabled=True initialized=True; with this change it endsenabled=False initialized=False.pyright src/rapidata/rapidata_client/config: 0 errors.🔗 Session: https://poseidon.rapidata.internal/chat/node-84f2b825850d
🤖 Generated with Claude Code