Skip to content

[Tftp] Add ntohs() to the pack->info.block then get the right block number #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lvtaolong wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Tftp] Add ntohs() to the pack->info.block then get the right block number #112

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b4fbad
Update tftp_xfer.c
lvtaolong Sep 11, 2026
193a20b
Merge pull request #1 from lvtaolong/lvtaolong-patch-1
lvtaolong Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tftp/tftp_xfer.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,9 @@ int tftp_read_data(struct tftp_xfer *xfer, struct tftp_packet *pack, int len)
tftp_printf("err[%d] msg:%s code:%d\n", ntohs(pack->info.code), pack->data, ntohs(pack->info.code));
return -TFTP_ECMD;
}
else if ((_private->block + 1) != pack->info.block)
else if ((_private->block + 1) != ntohs(pack->info.block))
{
tftp_printf("Bad block recv:%d != check:%d\n", _private->block + 1, pack->info.block);
tftp_printf("Bad block recv:%d != check:%d\n", _private->block + 1, ntohs(pack->info.block));
return -TFTP_EBLK;
}

Expand Down