-
Notifications
You must be signed in to change notification settings - Fork 52
docs - add examples and run spellcheck #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: asar_19
Are you sure you want to change the base?
Conversation
use a different value for each part of the data, so it is clear exactly which one is being calculated to.
|
A couple of questions:
Is this actually reading from the output ROM? Should that say "input ROM" instead?
|
|
Asar is primarily a patcher, so yes, input and output ROM are the same. And yes, as you said, readN() only cares about the original input bytes. Having it read its output would yield too much potential for self-contradictory or otherwise impossible patches, like |
|
For what it's worth, we are looking at splitting this. So changing that to input rom (or maybe source rom?) would be more clear. |
|
Thank you for the replies. Okay, I can go change a few occurrences of 'input ROM' -> 'output ROM' if that is helpful. |
the html validator at https://validator.w3.org/ says this is an extra tag error and shouldn't be here / not needed. rendering the page makes very little visual difference to me
the validator at https://validator.w3.org/ complains that 'be' is not valid in that position. I do not think that 'be' is a valid html tag most likely a typo
this might be more clear. not using the letters 'mov' so much so close together
…adered make it easier to read
easier to read with paragraphs
|
Overall the manual looks good. Great work on writing it. There are two other things I could edit if you want:
Or let me know if there is anything else you want edited or fixed. |
|
Okay I removed the trailing slashes, but that makes the diff pretty large and ugly. I don't know about you but I find that difficult to read and see the actually important changes. Let me remove those commits from this PR and I can put them into a separate PR. |
all other functions in the built-in functions list have three columns. the last one only has two. add a blank column so it matches, and the html validates
a77ec9f to
b5a77fd
Compare
|
Okay I removed the two commits. This should be much more readable now. Putting the 'trailing-slash' changes into their own PR will look like this: culix-7#1 . I can follow up with that after if you like. I would consider this PR done and good enough for now, but let me know if you want anything else. |
Thanks for creating asar. It is just excellent.
What do you think about adding a few examples to the docs to show how things work and make a few items more clear?
e.g. I added an example of creating a label based on another label plus some math, and added text explaining how math statements cannot use whitespace.
As a new user trying out the tool for the first time these behaviours weren't quite clear to me, so it might be nice to expand on them a bit.
I also fixed up a couple of variable names so they match the code block mentioned just above them, and ran spellcheck to fix a couple of words.
I'm happy to make these same edits in the version 2 manual if you want.