tune triton gemm kernel for MI355 DSV3 DP+EP configuration#2016
Open
tune triton gemm kernel for MI355 DSV3 DP+EP configuration#2016
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Triton GEMM tuning configs for gfx950 (MI355) targeting the A8W8 blocks-scale path for specific (N, K) shapes and small-M specializations.
Changes:
- Add new tuned config files for (N=7168, K=16384) and (N=16384, K=1536).
- Refine existing per-M-threshold tuning parameters (block sizes, warps/stages, waves_per_eu, k-splitting).
- Add/adjust ultra-small M special-cases (e.g.,
M_LEQ_8) for some shapes.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| aiter/ops/triton/configs/gemm/gfx950-GEMM-A8W8_BLOCKSCALE-N=7168-K=2048.json | Retunes per-M configs and adds M_LEQ_8 specialization for K=2048. |
| aiter/ops/triton/configs/gemm/gfx950-GEMM-A8W8_BLOCKSCALE-N=7168-K=16384.json | Adds a new tuned config for larger K=16384. |
| aiter/ops/triton/configs/gemm/gfx950-GEMM-A8W8_BLOCKSCALE-N=4096-K=7168.json | Retunes per-M configs and adds M_LEQ_8 specialization for N=4096/K=7168. |
| aiter/ops/triton/configs/gemm/gfx950-GEMM-A8W8_BLOCKSCALE-N=2112-K=7168.json | Retunes per-M configs, adds M_LEQ_8, and introduces M_LEQ_256. |
| aiter/ops/triton/configs/gemm/gfx950-GEMM-A8W8_BLOCKSCALE-N=16384-K=1536.json | Adds a new tuned config for N=16384/K=1536. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+62
to
+73
| "any": { | ||
| "BLOCK_SIZE_M": 64, | ||
| "BLOCK_SIZE_N": 64, | ||
| "BLOCK_SIZE_K": 128, | ||
| "GROUP_SIZE_M": 8, | ||
| "num_warps": 4, | ||
| "num_stages": 2, | ||
| "waves_per_eu": 1, | ||
| "matrix_instr_nonkdim": 16, | ||
| "cache_modifier": null, | ||
| "NUM_KSPLIT": 1 | ||
| } |
There was a problem hiding this comment.
This JSON appears to be missing the final closing brace for the root object. The last line closes the any object, but there is no subsequent } to close the top-level {, making the file invalid JSON. Add a final } at end-of-file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decode Side. cc @Duyi-Wang