Collapse jax build/test double-counting by normalizing jax_ref to bare version - #84
Open
HereThereBeDragons wants to merge 2 commits into
Open
Collapse jax build/test double-counting by normalizing jax_ref to bare version#84HereThereBeDragons wants to merge 2 commits into
HereThereBeDragons wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We fix a double-counting bug in the release status.json where every jax build
and test cell is counted twice. The cause is that one jax version reaches the
status pipeline under two spellings: the build matrix names cells by git ref
(
rocm-jaxlib-v0.11.0), while the release orchestrator and test dispatch inputsuse the bare version (
0.11.0). Left un-normalized, the two spellings key twodistinct variants that never merge, doubling the jax counts.
We normalize every jax ref to the bare version at the two points a ref enters a
variant key, so the two spellings collapse to a single (py, version) cell. On
the affected release this reduces the jax variant count from 30 to 15.
Change
_normalize_ref(axis_key, ref), called uniformly for every fan-out axis.Today only jax needs it: a
jax_refvalue has therocm-jaxlib-vprefixstripped, and the torch axis is a pure passthrough.
_variants_from_jobs(job-name parsing) and
_variants_from_inputs(dispatch-input parsing).We strip the prefix rather than add it because stripping is idempotent on
already-bare refs and never mangles a non-version ref such as a branch name.
Tests
collapses to one variant with a single key.
confirming the torch axis is unaffected.
Scope
The fix applies to future releases only. The already-frozen
20260820/status.jsonis not retroactively corrected.