Extend v2 gemm#754
Open
coderfeli wants to merge 10 commits into
Open
Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
- preshuffle_gemm_v2: fx.recast_iter(Int8, ...) instead of building an explicit PointerType (per @sjfeng1999) - universal.py: restore the Current atom state / soffset docstring note Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Bind the A (read) and C (store) buffer descriptors to the actual M extent (num_records) so blocks covering rows past M for ragged M drop their OOB loads/stores instead of faulting / writing past the allocation, matching v1 (preshuffle_gemm.py) behavior. Test: the shared harness now allocates guard rows past M (sentinel-filled) and asserts nothing is written beyond row M. Adds test_v2_preshuffle_c_store_oob covering the v2 kernel (fp8/int8/fp16/bf16) on a ragged M=33 shape. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
coderfeli
force-pushed
the
extend_v2_gemm
branch
from
f2de034 to
792111c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist