[WS2][PR5][Attention] Add distributed CP drift benchmark artifacts - #285
Open
inaniloquentee wants to merge 27 commits into
Open
[WS2][PR5][Attention] Add distributed CP drift benchmark artifacts#285inaniloquentee wants to merge 27 commits into
inaniloquentee wants to merge 27 commits into
Conversation
Signed-off-by: inaniloquentee <3051000145@qq.com>
Signed-off-by: inaniloquentee <3051000145@qq.com>
Signed-off-by: inaniloquentee <3051000145@qq.com>
Signed-off-by: inaniloquentee <3051000145@qq.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 12, 2026
Open
# Conflicts: # docs/operators/attention.md # rl_engine/kernels/ops/pytorch/attention/cp_attention.py # tests/test_cp_attention.py
inaniloquentee
changed the base branch from
codex/ws2-pr8-cp-attention-backward
to
test
August 12, 2026 16:13
Signed-off-by: lamentropetion <3051000145@qq.com>
Signed-off-by: lamentropetion <3051000145@qq.com>
Signed-off-by: lamentropetion <3051000145@qq.com>
Signed-off-by: lamentropetion <3051000145@qq.com>
Signed-off-by: lamentropetion <3051000145@qq.com>
Signed-off-by: lamentropetion <3051000145@qq.com>
Signed-off-by: lamentropetion <3051000145@qq.com>
inaniloquentee
force-pushed
the
codex/ws2-pr5-cp-attention-drift
branch
from
August 17, 2026 12:58
1803e34 to
3347ecd
Compare
inaniloquentee
force-pushed
the
codex/ws2-pr5-cp-attention-drift
branch
from
August 17, 2026 13:21
3347ecd to
2a0a600
Compare
This was referenced Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements PR5 of #235: the rank-aware WS2 Attention acceptance runner, report schema, and fail-closed validation for distributed forward, backward, communication, and repeatability evidence.
Gate
p2p_nccl_reference(Out, LSE)merge; no strict training autograd claimcuda_ag_rs --strict-shared-coreThe validator rejects CPU/dry-run-only evidence, missing CUDA/NCCL, incomplete topology/manifests, fallback, non-FP32 merge state, wrong downcast point, missing gradients, or non-bitwise repeats.
Strict H100 results
0.00.00.0Every rank reported
global_failure_count=0,core_id=rlkernel.attention.deterministic_core.v1,fallback=false,native_attention_arithmetic=false, andcommunication_autograd=true.Evidence
strict-shared-core-agrs-2rank-8309b77.jsonstrict-shared-core-agrs-tp2-cp2-4rank-8309b77.jsonstrict-shared-core-agrs-tp2-cp2-replica2-8rank-8309b77.json22 passedBoundary
This PR accepts operator-level Attention evidence. It does not turn optional native TE/FlashInfer arithmetic, AllReduce, or an unfurnished Megatron/vLLM checkpoint run into a required result. The executable strict path is owned by #279; backward semantics are owned by #284. Related: #235, #294.