Repository navigation
fix: add explicit Apply and missing-value filtering for boolean columns - #1886
Merged
Fred-Wu merged 1 commit intoOct 21, 2026
Merged
Conversation
Fred-Wu
marked this pull request as ready for review
October 20, 2026 12:20
renkun-ken
approved these changes
Oct 21, 2026
renkun-ken
left a comment
Member
There was a problem hiding this comment.
Reviewed commit 18b4f5e780611c10c8d4a7a96975ac562654c60d. No actionable issues found.
I exercised the shared viewer script with AG Grid 36.2.0 in headless Chrome, using both the client-side row model and an infinite-row datasource harness backed by fixtures from this commit's sess implementation:
- Selecting or changing True/False/Blank leaves the applied filter and displayed rows unchanged until Apply; the infinite datasource receives no extra request while editing the selection.
- Applying True and False excludes missing values. Blank selects only the missing rows, and its generated filter model is accepted by the R backend.
- Reset restores all rows; toggling floating filters and restoring saved viewer state preserve the applied boolean filter.
Validation passed: all 13 data-viewer unit tests, TypeScript compilation, lint, and 195 R data-viewer assertions using the exact prepared dist/resources/sess installed in a temporary library. Direct backend checks on c(TRUE, FALSE, NA, TRUE, FALSE, NA) also passed for all three operators. Current macOS, Ubuntu, Windows, build, and lint CI checks are green.
Member
|
Formatting error should be fixed #1891. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Boolean-column filters currently apply immediately when a choice is selected. This can trigger accidental data fetching before the user finishes choosing a filter, particularly for large datasets.
This change:
Applybutton alongside Reset so users explicitly apply their selection.Blankchoice to filterNAvalues in boolean columns such asc(TRUE, FALSE, NA).Validation: all 13 data-viewer unit tests, TypeScript checks, and lint pass. New tests cover filter options, button configuration, and True/False predicates excluding missing values. Browser interaction has not been tested.