#294 feat: domain operations on the transaction adapter - #295
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #294
A command declaring
sets(...)generated its UPDATE only on the pool repository, so an operation that has to commit together with other writes had to be rewritten as raw SQL — the thing declaring it was meant to prevent.The adapter now carries the same operations: same statement, same compile-time column checking, executed against the transaction. A missing row is
Ok(None)rather than an error, matching the adapter's other methods.Covered by a live test that runs the operation inside a transaction, rolls back and proves the write went with it, and asserts an unknown id reports no row. Documented in the README and the commands page in all five wiki languages.