fix: skip action rows with blank player name to prevent write-queue s… - #389
Open
netcrafts wants to merge 1 commit into
Open
fix: skip action rows with blank player name to prevent write-queue s…#389netcrafts wants to merge 1 commit into
netcrafts wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Extends the existing skip-and-warn guard in
insertActionsto also discard actions whosesourceProfilecarries a blank name, and renamessafe/oversizedtovalid/invalidso the variable names remain accurate now that two discard conditions exist.Why?
Under certain conditions — likely a mod generating a player-attributed action for an entity with an incomplete
GameProfile—getOrCreatePlayerIdattempts to insert a new row intoplayerswhereNameAndId.nameis blank. Because the genericgetOrCreateObjectIdhelper only sets the single column passed to it (player_id),player_nameis omitted from the INSERT. MySQL rejects this asplayer_nameisNOT NULLwith no default:The exception propagates out of
insertActions, the action is never removed from the queue, and the write pipeline stalls retrying the same batch indefinitely.How?
One extra condition is added to the existing
partitionpredicate:The
invalid.forEachwarn block now branches on the cause so each case logs a distinct, actionable message. The warning includes the UUID, which should help identify the source if the issue is encountered again.