Open
Conversation
Deploy Resultsℹ️ No tests to run No changed packages with deploy targets were discovered for this PR. Test Results
5 tested, 5 passed, 0 failed in 15.8s · View logs |
Quenty
reviewed
Apr 1, 2026
|
|
||
| if self._removing[userId] then | ||
| return Promise.defer(function(resolve) | ||
| while self._removing[userId] do |
Owner
There was a problem hiding this comment.
very paranoid, but can we add a if-statement if we yield for longer than 15s removing we should warn that it took > 15s to remove and reject the promise? That will stop us from leaking these removal threads.
Otherwise we may end up in a scenario where something fails to fully remove a datastore and then we stop the player from being able to join, and we'll never get clear errors, thus leaking the server forever.
Collaborator
Author
There was a problem hiding this comment.
updated here: c4e5a27
how is this looking?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
edits PlayerDataStoreService.PromiseDataStore to use new method PlayerDataStoreManager.PromiseDataStore instead of GetDataStore.
new method PlayerDataStoreManager.PromiseDataStore will resolve with the datastore object. if previous session data is still cleaning up or saving, it will wait for this to complete before fetching the datastore instead of returning nil