Update search UX - #52
Merged
Merged
Conversation
n13
approved these changes
Sep 23, 2026
n13
left a comment
n13
left a comment
There was a problem hiding this comment.
Reviewer model: GPT 5.6 Sol
APPROVE — no blocking findings.
The shared search hook preserves the existing header and landing-page behavior while only navigating on Enter when the visible result belongs to the current input. The route helpers keep Enter navigation aligned with preview links, and collapsing by destination path removes batch-transfer duplicates without merging transactions that open different detail pages.
Validation:
npx --yes bun@1.2.16 test— 66 tests passed, including all 12 added search tests.npx --yes bun@1.2.16 run build— Vite production build andtscpassed.- Changed-file ESLint and Prettier checks passed.
git diff --checkpassed.- GitHub's dependency-cooldown check passed. The main CI workflow does not run for this feature-branch target, so build/test evidence is local.
No blocking findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.