Skip to content

fix(gap-3): active plastics-domain inference rules registry (6 rules)#82

Open
cryptoxdog wants to merge 2 commits into
base/pre-gap-fixesfrom
fix/gap3-inference-rule-registry
Open

fix(gap-3): active plastics-domain inference rules registry (6 rules)#82
cryptoxdog wants to merge 2 commits into
base/pre-gap-fixesfrom
fix/gap3-inference-rule-registry

Conversation

@cryptoxdog

Copy link
Copy Markdown
Collaborator

Gap 3

File: engine/inference_rule_registry.py

Replaces empty stub with 6 production inference rules for the plastics domain.

Rule Inputs Output
infer_company_size_tier employee_count / revenue micro/small/mid/large
infer_facility_tier_from_capacity processing_capacity_tons_per_year micro/small/mid/large
infer_material_grade_from_mfi melt_flow_index + material_type HD_pipe / HD_injection / PP_*
infer_contamination_tolerance facility_tier + material_grade high/medium/low
infer_icp_fit_score multi-factor composite 0.0–1.0 float
infer_buyer_persona tier + grade + tolerance prime_buyer / processor / opportunistic / standard

All pure functions. icp_fit_score requires ≥2 contributing factors.

Tests: tests/gap_fixes/test_gap3_inference_registry.py — 6 cases

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Mar 31, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: fc30b1d2-b361-4099-9216-80b5cf2d9e48

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/gap3-inference-rule-registry

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown

PR size is within recommended limits

@sonarqubecloud

Copy link
Copy Markdown

@cryptoxdog

Copy link
Copy Markdown
Collaborator Author

PR #82 Review: fix(gap-3): active plastics-domain inference rules registry (6 rules)

Author: cryptoxdog
Branch: fix/gap3-inference-rule-registry
HEAD: 6d3bf0ee
Created: 2026-03-31T07:23:15Z
Changes: +278 / -0
Reviewed: 2026-04-21T18:09:36+00:00

Description

Gap 3

File: engine/inference_rule_registry.py

Replaces empty stub with 6 production inference rules for the plastics domain.

Rule Inputs Output
infer_company_size_tier employee_count / revenue micro/small/mid/large
infer_facility_tier_from_capacity processing_capacity_tons_per_year micro/small/mid/large
infer_material_grade_from_mfi melt_flow_index + material_type HD_pipe / HD_injection / PP_*
infer_contamination_tolerance facility_tier + material_grade high/medium/low
infer_icp_fit_score multi-factor composite 0.0–1.0 float
infer_buyer_persona tier + grade + tolerance prime_buyer / processor / opportunistic / standard

All pure functions. icp_fit_score requires ≥2 contributing factors.

Tests: tests/gap_fixes/test_gap3_inference_registry.py — 6 cases

Commits

6d3bf0ee fix(gap-3): active plastics-domain inference rules registry (6 rules)

Changed Files

🐍 Python (3 files)

  • engine/inference_rule_registry.py
  • tests/gap_fixes/__init__.py
  • tests/gap_fixes/test_gap3_inference_registry.py

Automated Analysis

Diff Findings

✅ No issues found in diff analysis

Test Coverage

Files without corresponding test changes:

  • engine/inference_rule_registry.py

Local Lint

Skipped (repo not checked out locally or linters not found).

Summary

LOOKS GOOD — No automated issues found. Ready for human review.


Automated PR review • 2026-04-21 18:09

@cryptoxdog

Copy link
Copy Markdown
Collaborator Author

Automated PR patrol review — 2026-04-22 UTC

Patrol note only; not a human approval. This PR has been open for 538.6h with no review.

  • CI status: FAILURE
  • Review decision: NONE
  • Draft: False
  • Files changed: 3 (python:3)
  • Heuristic scan: No heuristic diff issues detected.

Top findings:

  • No heuristic diff issues detected.

Suggested next action: fix failing CI, then request review .

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant