feat: Improve existing numeric metrics for new output format#44
Open
Moritz Potthoff (MoritzPotthoffQC) wants to merge 7 commits into
Open
feat: Improve existing numeric metrics for new output format#44Moritz Potthoff (MoritzPotthoffQC) wants to merge 7 commits into
Moritz Potthoff (MoritzPotthoffQC) wants to merge 7 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## generalize-metrics-add-nullability #44 +/- ##
====================================================================
Coverage 100.00% 100.00%
====================================================================
Files 11 11
Lines 1030 1035 +5
====================================================================
+ Hits 1030 1035 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was referenced Jul 10, 2026
Merged
Copilot started reviewing on behalf of
Moritz Potthoff (MoritzPotthoffQC)
July 10, 2026 14:28
View session
There was a problem hiding this comment.
Pull request overview
This PR updates Diffly’s metric outputs to use the newer “old -> new (delta)” rendering for existing numeric metrics, and propagates that change through unit tests and golden summary fixtures (including CLI-visible metric labels).
Changes:
- Update
tests/test_metrics.pyexpectations for numeric preset metrics to assert formatted change strings (e.g.,2.0 -> 3.0 (+1.0)). - Update
summary.to_json()expectations and many golden summary fixtures to reflect the new rendered metric values/layout. - Rename the null-fraction preset label used in tests/fixtures/CLI from
ΔNull%toNull%.
Reviewed changes
Copilot reviewed 165 out of 165 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_metrics.py | Updates metric unit tests to expect formatted <old> -> <new> (<delta>) strings for numeric presets. |
| tests/summary/test_summary.py | Updates JSON summary expectations for metrics to match new rendered string values. |
| tests/cli/test_cli.py | Updates CLI test to request/display the renamed null-fraction metric preset (Null%). |
| tests/summary/fixtures/metrics_null_fraction/test_metrics_null_fraction.py | Updates fixture generator test to use the renamed null-fraction preset label (Null%). |
| tests/summary/fixtures/metrics_presets_many/gen/*.txt | Regenerates golden fixtures to reflect new metric rendering and resulting table wrapping. |
| tests/summary/fixtures/metrics_presets_few/gen/*.txt | Regenerates golden fixtures to reflect new metric rendering and resulting table wrapping. |
| tests/summary/fixtures/metrics_null_fraction/gen/*.txt | Regenerates golden fixtures for null-fraction metrics to reflect the new label and rendering. |
| tests/summary/fixtures/metrics_long_labels/gen/*.txt | Regenerates golden fixtures to reflect new metric rendering under long-header layout constraints. |
| tests/summary/fixtures/metrics_custom/gen/*.txt | Regenerates golden fixtures to reflect new metric rendering for user-supplied metrics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ty' into delta-metrics
…ty' into delta-metrics
Copilot started reviewing on behalf of
Moritz Potthoff (MoritzPotthoffQC)
July 10, 2026 15:33
View session
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
It would be nice to apply the new output format of #43 (
<old> -> <new> (<delta>)) also to all existing metrics where it makes sense.Changes