Skip to content

Update jupyter/ydoc #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinRenou merged 1 commit into from
Jun 19, 2026
Merged

Update jupyter/ydoc #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,12 @@
"watch:labextension": "jupyter labextension watch ."
},
"dependencies": {
"@jupyter/ydoc": "^2.0.0 || ^3.0.0-a3",
"@jupyterlab/application": "^4.0.0",
"@jupyterlab/apputils": "^4.0.0",
"@jupyterlab/console": "^4.2.4",
"@jupyterlab/coreutils": "^6.0.0",
"@jupyterlab/notebook": "^4.0.0",
"@jupyter/ydoc": "^2.0.0 || ^3.0.0 || ^4.0.0",

@davidbrochart davidbrochart Jun 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have changed that:

Suggested change
"@jupyter/ydoc": "^2.0.0 || ^3.0.0 || ^4.0.0",
"@jupyter/ydoc": "^4.0.0",

@martinRenou martinRenou Jun 19, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I disagree, this would be the source for the kind of issue we see in JupyterGIS right now with having duplications of packages leading to build errors.

@davidbrochart davidbrochart Jun 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But you updated to jupyterlab v4.6 which does just that.

@martinRenou martinRenou Jun 19, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is only on a minor bump so the solver should normally not duplicate versions just for this

@davidbrochart davidbrochart Jun 19, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, the point is you should not self-merge.

@martinRenou martinRenou Jun 19, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many repos where we are short of maintainers, so self merge is just mandatory if we want things to move on. I would definitely have asked a review on a code change I wasn't sure of. But for this, this is a no-brainer.

"@jupyterlab/application": "^4.6",
"@jupyterlab/apputils": "^4.6",
"@jupyterlab/console": "^4.6",
"@jupyterlab/coreutils": "^6.6",
"@jupyterlab/notebook": "^4.6",
"@jupyterlab/services": "^7.0.0",
"@lumino/coreutils": "^2.1.1",
"@lumino/signaling": "^2.1.1",
Expand Down
Loading
Loading