Repoint ols data reads to this repo's own copies#966
Merged
Conversation
The three data reads in the lecture body (maketable1/2/4) still fetched from the retired QuantEcon/lecture-python repo, leaving this lecture dependent on a repo the series no longer maintains. Identical copies are already committed under lectures/_static/lecture_specific/ols/ and are already what the solutions read, so the body now uses them too and the URL form matches the solutions exactly. Verified byte-identical before repointing: sha256 of each own-repo copy matches the legacy-repo file, so lecture output is unchanged. Confirmed the new URLs serve those same bytes and that pd.read_stata() parses all three (163 rows each, expected columns present). Part of QuantEcon/meta#337 See QuantEcon/meta#336 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the ols lecture to fetch its .dta datasets from this repository’s vendored copies (under lectures/_static/lecture_specific/ols/) via GitHub raw URLs, removing dependency on the retired QuantEcon/lecture-python repo while keeping the data source content identical.
Changes:
- Repoint the main-body
pd.read_stata()calls formaketable1.dta,maketable2.dta, andmaketable4.dtatoQuantEcon/lecture-python.mystraw URLs. - Align the lecture body’s data-read URLs with the URL form already used in the solutions cells.
📖 Netlify Preview Ready!Preview URL: https://pr-966--sunny-cactus-210e3e.netlify.app Commit: 📚 Changed LecturesBuild Info
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The three data reads in the body of
ols.md(maketable1,maketable2,maketable4) still fetched from the retiredQuantEcon/lecture-pythonrepo viablob/master/…?raw=true, leaving this lecture dependent on a repo the series no longer maintains. Identical copies are already committed underlectures/_static/lecture_specific/ols/— and are already what the solutions in this same lecture read. This points the body at them too, using the same URL form the solutions use.Verification
Byte-compare before repointing, so this cannot change lecture output:
maketable1.dta7a8687cc…7a8687cc…7a8687cc…maketable2.dta7f0dc30d…7f0dc30d…7f0dc30d…maketable4.dta2b34cce2…2b34cce2…2b34cce2…All three sha256 sums are identical across all three columns. Also confirmed
pd.read_stata()parses each of the new URLs — 163 rows each, expected columns present — so this is verified against the real fetch path, not just an HTTP status check.Scope
This is the
olshalf of the legacy-reference cleanup in QuantEcon/meta#337. The remainingpandas_panelreferences are deliberately left alone: those files are migrating toQuantEcon/data-lecturesas pilot P2 (QuantEcon/meta#338), so an interim repoint here would be churn.Part of QuantEcon/meta#337
See QuantEcon/meta#336