Validate buying power for combo order updates - #9750
Open
mameikagou wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stage combo legs on isolated copies, apply the proposed update to the staged group, and validate buying power before mutating the live order. Rejected updates now leave the combo group unchanged and never reach the brokerage.
Related Issue
Fixes #8567
Motivation and Context
Combo order updates skipped buying-power validation, allowing updates that exceeded available margin.
Requires Documentation Change
No.
How Has This Been Tested?
Built
QuantConnect.Testswith .NET 10 and ran seven focused brokerage transaction-handler tests in a bounded Docker environment, including the new accepted and rejected combo-update cases. All seven passed.Types of changes
Checklist:
bug-<issue#>-<description>orfeature-<issue#>-<description>