Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Common/Data/Market/Session.cs
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,18 @@ public Session(TickType tickType, SecurityExchangeHours exchangeHours, Symbol sy
/// <param name="data">The new data to update the session with</param>
public void Update(BaseData data)
{
if (data is IBaseDataBar && data.EndTime - data.Time >= Time.OneDay)
{
var sessionBar = new SessionBar(_tickType)
{
Time = data.Time.Date,
Symbol = _symbol
};
sessionBar.Update(data, null);
Add(sessionBar);
return;
}

_consolidator?.Update(data);
}

Expand Down
33 changes: 32 additions & 1 deletion Tests/Indicators/SessionTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,33 @@ public void ConsolidatesDaily(DateTime baseDate, Resolution resolution)
}
}

[Test]
public void DailyQuoteBarsPopulateSessionDirectly()
{
var symbol = Symbols.EURUSD;
var session = GetSession(symbol, TickType.Quote, 10);
var start = new DateTime(2024, 9, 16);

for (var i = 0; i < 5; i++)
{
var time = start.AddDays(i);
session.Update(new QuoteBar(
time,
symbol,
new Bar(1.10m + i, 1.11m + i, 1.09m + i, 1.105m + i),
0,
new Bar(1.12m + i, 1.13m + i, 1.11m + i, 1.125m + i),
0,
Time.OneDay));
}

Assert.AreEqual(6, session.Samples);
Assert.AreEqual(start.AddDays(4), session[0].Time);
Assert.AreEqual(start.AddDays(5), session[0].EndTime);
Assert.AreEqual(5.11m, session[0].Open);
Assert.AreEqual(5.115m, session[0].Close);
}

[TestCaseSource(nameof(NextSessionTradingDayCases))]
public void CreatesNewSessionBarWithCorrectNextTradingDay(DateTime startDate, DateTime expectedDate)
{
Expand Down Expand Up @@ -173,7 +200,11 @@ private static IEnumerable<TestCaseData> NextSessionTradingDayCases()

private static Session GetSession(TickType tickType, int initialSize)
{
var symbol = Symbols.SPY;
return GetSession(Symbols.SPY, tickType, initialSize);
}

private static Session GetSession(Symbol symbol, TickType tickType, int initialSize)
{
var marketHoursDatabase = MarketHoursDatabase.FromDataFolder();
var exchangeHours = marketHoursDatabase.GetExchangeHours(symbol.ID.Market, symbol, symbol.SecurityType);
return new Session(tickType, exchangeHours, symbol, initialSize);
Expand Down