feat(service): add external secrets to creation flow#2720
Open
rmnbrd wants to merge 1 commit into
Open
Conversation
12 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feat/secrets-manager-cluster-creation-flow #2720 +/- ##
==============================================================================
- Coverage 45.58% 45.50% -0.08%
==============================================================================
Files 707 1151 +444
Lines 17731 24578 +6847
Branches 5338 7300 +1962
==============================================================================
+ Hits 8082 11185 +3103
- Misses 8198 11401 +3203
- Partials 1451 1992 +541
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds external secrets support during service creation, including variable flow data, summary rendering, secret manager selection helpers, and the add-secret modal used by app/container/job creation flows.
Screenshots / Recordings
Testing
yarn testoryarn test -u(if you need to regenerate snapshots)yarn formatyarn lintPR Checklist
.cursor/rules)feat(service): add new Terraform service) - required for semantic-release