Skip to content

feat(argocd): add ArgoCD associated services modal#2717

Draft
RemiBonnet wants to merge 1 commit into
stagingfrom
feat/argocd-associated-services
Draft

feat(argocd): add ArgoCD associated services modal#2717
RemiBonnet wants to merge 1 commit into
stagingfrom
feat/argocd-associated-services

Conversation

@RemiBonnet
Copy link
Copy Markdown
Member

Summary

Issue:

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@codecov
Copy link
Copy Markdown

codecov Bot commented May 29, 2026

Codecov Report

❌ Patch coverage is 70.58824% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.96%. Comparing base (ca77a24) to head (bbb0658).

Files with missing lines Patch % Lines
...st-modal/argocd-associated-services-list-modal.tsx 70.37% 5 Missing and 3 partials ⚠️
...ociated-services/use-argocd-associated-services.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2717      +/-   ##
===========================================
- Coverage    46.95%   45.96%   -1.00%     
===========================================
  Files         1165     1169       +4     
  Lines        24414    24573     +159     
  Branches      7173     7224      +51     
===========================================
- Hits         11463    11294     -169     
- Misses       10950    11316     +366     
+ Partials      2001     1963      -38     
Flag Coverage Δ
unittests 45.96% <70.58%> (-1.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant